[webkit-reviews] review denied: [Bug 78398] [Chromium] Add video stream texture support : [Attachment 126602] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Daniel Sievers
<sievers at chromium.org>'s request for review:
Bug 78398: [Chromium] Add video stream texture support
https://bugs.webkit.org/show_bug.cgi?id=78398

Attachment 126602: Patch
https://bugs.webkit.org/attachment.cgi?id=126602&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126602&action=review


> Source/WebKit/chromium/public/WebMediaPlayer.h:166
> +    virtual WebStreamTextureProxy* createStreamTextureProxy() { return 0; }

nit: normally the peer to a created interface is a *Client interface, and
normally a *Client instance is passed as a parameter to the create* function. 
See WebKitPlatformSupport::createURLLoader for example.

> Source/WebKit/chromium/public/WebStreamTextureProxy.h:37
> +class WebStreamTextureProxy {

what is a WebStreamTextureProxy?  It seems to have the properties that it can
tell its client when a "frame" is available and it can also push a new matrix. 
where is the data for the frame?

> Source/WebKit/chromium/public/WebStreamTextureProxy.h:44
> +	   virtual void onFrameAvailable() = 0;

nit: we don't use the "on" prefix in the webkit api.  we use did/will prefixes
so that we are more precise about if the notification is happening before or
after a state change.