[webkit-reviews] review denied: [Bug 78404] [chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure : [Attachment 126614] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 78404: [chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure
https://bugs.webkit.org/show_bug.cgi?id=78404

Attachment 126614: Patch
https://bugs.webkit.org/attachment.cgi?id=126614&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126614&action=review


I like everything except the TreeSynchronizer change.  TreeSynchronizer
shouldn't be instantiable, it should just be pure functions.

> Source/WebCore/platform/graphics/chromium/TreeSynchronizer.h:51
> +    TreeSynchronizer() { }

why did you change this? i much prefer having tree syncing be a pure function,
this is weird