[webkit-reviews] review granted: [Bug 74154] [chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap : [Attachment 126555] Rebased to ToT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 18:30:54 PST 2012


James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 74154: [chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
https://bugs.webkit.org/show_bug.cgi?id=74154

Attachment 126555: Rebased to ToT
https://bugs.webkit.org/attachment.cgi?id=126555&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126555&action=review


R=me

> Source/WebCore/platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:50
> +    static PassOwnPtr<DrawableTile> create() { return adoptPtr(new
DrawableTile()); }

nit: i normally omit the () from the c'tor call here. not a strong preference


More information about the webkit-reviews mailing list