[webkit-reviews] review denied: [Bug 72756] REGRESSION (r100805):=?UTF-8?Q?=20DOMHTMLElement=E2=80=99s=20accessKey=20property=20is=20declared=20as=20available=20in=20WebKit=20version=20that=20didn=E2=80=99t=20have=20it=20?=: [Attachment 126585] updated_patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 72756: REGRESSION (r100805): DOMHTMLElement’s accessKey property is
declared as available in WebKit version that didn’t have it
https://bugs.webkit.org/show_bug.cgi?id=72756

Attachment 126585: updated_patch
https://bugs.webkit.org/attachment.cgi?id=126585&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126585&action=review


> Source/JavaScriptCore/API/WebKitAvailability.h:913
> + * Used on functions introduced in WebKit 5.1
> + */
> +#define AVAILABLE_WEBKIT_VERSION_5_1_AND_LATER

This is still wrong. 5.1 has shipped, so changes in TOT can't be available in
5.1. This needs to be AVAILABLE_AFTER_WEBKIT_VERSION_5_1. I know it reads
funny, but thats the best we can do without predicting the future version
number.