[webkit-reviews] review granted: [Bug 77385] flex-pack:center and flex-item-align:center should do true centering : [Attachment 126552] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 77385: flex-pack:center and flex-item-align:center should do true centering
https://bugs.webkit.org/show_bug.cgi?id=77385

Attachment 126552: Patch
https://bugs.webkit.org/attachment.cgi?id=126552&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126552&action=review


If you wanted to be thorough, you could add writing mode tests.

> Source/WebCore/ChangeLog:9
> +	   Also, removed passing totalPositiveFlexibility around. We don't
> +	   need to know about positive/negative flex once we run the flexing
algorithm.

I remember why we had this.  It was when you could flex margins.  Maybe mention
that in the ChangeLog.