[webkit-reviews] review granted: [Bug 78325] CSS3 calc: update font-size test to use pre/post js : [Attachment 126448] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 78325: CSS3 calc: update font-size test to use pre/post js
https://bugs.webkit.org/show_bug.cgi?id=78325

Attachment 126448: Patch
https://bugs.webkit.org/attachment.cgi?id=126448&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126448&action=review


> LayoutTests/css3/calc/font-size.html:22
> +    shouldBeEqualToString('getComputedStyle(document.getElementById("' +
spans[i].id + '"), null).fontSize',
getComputedStyle(document.getElementById("control"), null).fontSize);

In future tests, you could make this more readable by creating a helper
function: 
function fontSize(id) {
    return getComputedStyle(document.getElementById("' + id + '"),
null).fontSize;
}