[webkit-reviews] review granted: [Bug 72875] remove deprecated -f option of jsc shell : [Attachment 122640] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 10:22:59 PST 2012


Eric Seidel <eric at webkit.org> has granted Andy Wingo <wingo at igalia.com>'s
request for review:
Bug 72875: remove deprecated -f option of jsc shell
https://bugs.webkit.org/show_bug.cgi?id=72875

Attachment 122640: Patch
https://bugs.webkit.org/attachment.cgi?id=122640&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122640&action=review


Based on comment 12 and comment 18, this patch seems to satisfy the requests of
the reviewers.

> Source/JavaScriptCore/tests/mozilla/jsDriver.pl:152
> +    my $file_param = " ";

Why is this variable still needed if it's empty?  Just trying to change the
harness as little as possible?


More information about the webkit-reviews mailing list