[webkit-reviews] review denied: [Bug 71293] Change values for WEBKIT_KEYFRAMES_RULE, WEBKIT_KEYFRAME_RULE : [Attachment 126529] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 10:05:30 PST 2012


Chris Marrin <cmarrin at apple.com> has denied Edward O'Connor
<eoconnor at apple.com>'s request for review:
Bug 71293: Change values for WEBKIT_KEYFRAMES_RULE, WEBKIT_KEYFRAME_RULE
https://bugs.webkit.org/show_bug.cgi?id=71293

Attachment 126529: Patch
https://bugs.webkit.org/attachment.cgi?id=126529&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126529&action=review


Please add a test to verify the correct values

> Source/WebCore/ChangeLog:8
> +	   No tests.

We really should have a test. The fact that we didn't before means the error in
the values went undetected.


More information about the webkit-reviews mailing list