[webkit-reviews] review granted: [Bug 78062] DFG should have polymorphic put_by_id caching : [Attachment 125979] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 78062: DFG should have polymorphic put_by_id caching
https://bugs.webkit.org/show_bug.cgi?id=78062

Attachment 125979: the patch
https://bugs.webkit.org/attachment.cgi?id=125979&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125979&action=review


No baseline support? :-D

Once this is in we can add support for setters!!!!

> Source/JavaScriptCore/runtime/WriteBarrier.h:82
> +    
> +    // This is meant to be used like operator=, but is called copyFrom
instead, in
> +    // order to kindly inform the C++ compiler that its advice is not
appreciated.
> +    void copyFrom(const WriteBarrierBase<T>& other)
> +    {
> +	   m_cell = other.m_cell;
> +    }

What was it complaining about?