[webkit-reviews] review granted: [Bug 78236] Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console : [Attachment 126302] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 78236: Web Inspector: [TextPrompt] TAB should complete suggestions up to
their common prefix in Console
https://bugs.webkit.org/show_bug.cgi?id=78236

Attachment 126302: Patch
https://bugs.webkit.org/attachment.cgi?id=126302&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126302&action=review


> Source/WebCore/inspector/front-end/TextPrompt.js:445
> +	       }

Please extract this method.

> Source/WebCore/inspector/front-end/TextPrompt.js:516
> +	   if (!this.autoCompleteElement || !this._commonPrefix ||
!this._userEnteredText || this._userEnteredText.length >=
this._commonPrefix.length)

We'd better check that user entered text is prefix of common prefix.