[webkit-reviews] review requested: [Bug 72756] REGRESSION (r100805):=?UTF-8?Q?=20DOMHTMLElement=E2=80=99s=20accessKey=20property=20is=20declared=20as=20available=20in=20WebKit=20version=20that=20didn=E2=80=99t=20have=20it=20?=: [Attachment 126506] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 05:28:52 PST 2012


Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 72756: REGRESSION (r100805): DOMHTMLElement’s accessKey property is
declared as available in WebKit version that didn’t have it
https://bugs.webkit.org/show_bug.cgi?id=72756

Attachment 126506: proposed patch
https://bugs.webkit.org/attachment.cgi?id=126506&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
Adding AVAILABLE_WEBKIT_VERSION_5_1_AND_LATER in WebKitAvailability.h.
Also reverting the chenges in idl files moving then under #if
defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C.

In PublicDOMInterface.h marking accessKey property for HTMLAnchorElement,
HTMLAreaElement, HTMLButtonElement, HTMLInputElement, HTMLLabelElement,
HTMLLegendElement  and HTMLTextAreaElement 
 with an  availability macro
AVAILABLE_WEBKIT_VERSION_1_3_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_4_0.


Please let me know your review comments on these changes. Thanks.


More information about the webkit-reviews mailing list