[webkit-reviews] review granted: [Bug 78346] Web Inspector: implement undo for setOuterHTML via undo-ing nested primitive commands. : [Attachment 126494] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 78346: Web Inspector: implement undo for setOuterHTML via undo-ing nested
primitive commands.
https://bugs.webkit.org/show_bug.cgi?id=78346

Attachment 126494: Patch
https://bugs.webkit.org/attachment.cgi?id=126494&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126494&action=review


> Source/WebCore/inspector/DOMEditor.h:35
> +

Forward declaration should be enough

> Source/WebCore/inspector/InspectorCSSAgent.cpp:233
> +	   InspectorStyleSheet* styleSheet =
m_cssAgent->assertStyleSheetForId(0, m_styleSheetId);

It is unsafe to pass 0 here as the method might eventually start writing some
error string there

> Source/WebCore/inspector/InspectorCSSAgent.cpp:619
> +    *errorString = InspectorDOMAgent::toErrorString(ec);

Don't do this on success

> Source/WebCore/inspector/InspectorCSSAgent.cpp:635
> +    *errorString = InspectorDOMAgent::toErrorString(ec);

Ditto

> Source/WebCore/inspector/InspectorHistory.h:62
> +	   virtual bool perform(ExceptionCode&) = 0;

ExceptionCode should be forward declared