[webkit-reviews] review denied: [Bug 71816] [Qt] run-qtwebkit-tests doesn't consider crashes as failures : [Attachment 126500] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 04:56:28 PST 2012


Csaba Osztrogonac <ossy at webkit.org> has denied János Badics
<dicska at gmail.com>'s request for review:
Bug 71816: [Qt] run-qtwebkit-tests doesn't consider crashes as failures
https://bugs.webkit.org/show_bug.cgi?id=71816

Attachment 126500: proposed patch
https://bugs.webkit.org/attachment.cgi?id=126500&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
r-, because we shouldn't duplicate stdio. We can check the return 
value and the getText2 return value with one function call.


More information about the webkit-reviews mailing list