[webkit-reviews] review denied: [Bug 78278] [BlackBerry] Upstream graphics helper classes in WebKitSupport : [Attachment 126425] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 78278: [BlackBerry] Upstream graphics helper classes in WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=78278

Attachment 126425: Patch
https://bugs.webkit.org/attachment.cgi?id=126425&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126425&action=review


some more comments and questions ...

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:109
> +#if USE(SKIA)
> +    WebCore::PlatformContextSkia* platformGraphicsContext = new
WebCore::PlatformContextSkia(drawable);
> +#endif
> +    return platformGraphicsContext;

that wont build if !SKIA

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:119
> +PlatformGraphicsContext* SurfacePool::lockTileRenderingSurface() const
> +{
> +#if USE(SKIA)
> +    if (!m_tileRenderingSurface)
> +	   return 0;
> +    return
createPlatformGraphicsContext(BlackBerry::Platform::Graphics::lockBufferDrawabl
e(m_tileRenderingSurface));
> +#endif
> +}

that wont return anything if !SKIA

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:175
> +    // Create the m_visibleTileBuffer.

do we need these comment?

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:199
> +    // Release the m_visibleTileBuffer.

ditto

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:205
> +    // Release the backbuffer.

ditto

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.h:87
> +#if USE(SKIA)

maybe we should just drop the SKIA condition completely?