[webkit-reviews] review granted: [Bug 78304] Web Inspector: Prevent attaching when inspecting the Web Inspector : [Attachment 126414] Proposed Change

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 78304: Web Inspector: Prevent attaching when inspecting the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=78304

Attachment 126414: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=126414&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review


> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272
> +    unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4;

Is it worth it to use a constant for 3/4 like WebCore? It seems like we could
just put it in WebInspectorProxy.h next to minimumAttachedHeight.