[webkit-reviews] review granted: [Bug 78308] The JS Parser scope object needs a VectorTrait specialization : [Attachment 126421] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 78308: The JS Parser scope object needs a VectorTrait specialization
https://bugs.webkit.org/show_bug.cgi?id=78308

Attachment 126421: Patch
https://bugs.webkit.org/attachment.cgi?id=126421&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126421&action=review


> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:418
> +    if (1) {

Oooops, you probably want to remove that.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1227
> +	       if (JSActivation* activation =
jsDynamicCast<JSActivation*>(currentVariableObject))

Will this if be optimized out in release builds? – I'd prefer to see:
    ASSERT(!jsDynamicCast<JSActivation*>(currentVariableObject) ||
jsDynamicCast<JSActivation*>(currentVariableObject)->isValidScopedLookup(entry.
getIndex()));