[webkit-reviews] review granted: [Bug 78291] FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly : [Attachment 126388] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 15:38:38 PST 2012


mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 78291: FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll
correctly
https://bugs.webkit.org/show_bug.cgi?id=78291

Attachment 126388: Patch
https://bugs.webkit.org/attachment.cgi?id=126388&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=126388&action=review


> Source/WebCore/page/FrameView.cpp:1332
>      m_slowRepaintObjectCount++;
> +    if (m_slowRepaintObjectCount == 1)

This is one case where I think collapsing this into a single line would have
made things clearer:
    if (!m_slowRepaintObjectCount++)


More information about the webkit-reviews mailing list