[webkit-reviews] review granted: [Bug 78271] run-perf-tests should have an option to pause before running tests so we can attach Instruments : [Attachment 126351] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 12:47:08 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 78271: run-perf-tests should have an option to pause before running tests
so we can attach Instruments
https://bugs.webkit.org/show_bug.cgi?id=78271

Attachment 126351: Patch
https://bugs.webkit.org/attachment.cgi?id=126351&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126351&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:196
> +	       self.assertEqual(stderr, "Ready to run test?\n")

It's strange that we use stderr for this


More information about the webkit-reviews mailing list