[webkit-reviews] review granted: [Bug 70845] ASSERTION FAILED: checkURLReceivedFromWebProcess(originalURL) loading a local file, if the WebProcess crashed : [Attachment 126197] with a typo fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 12:39:01 PST 2012


Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 70845: ASSERTION FAILED: checkURLReceivedFromWebProcess(originalURL)
loading a local file, if the WebProcess crashed
https://bugs.webkit.org/show_bug.cgi?id=70845

Attachment 126197: with a typo fixed
https://bugs.webkit.org/attachment.cgi?id=126197&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126197&action=review


> Source/WebKit2/UIProcess/WebProcessProxy.cpp:250
> +    for (WebBackForwardListItemMap::iterator iter =
m_backForwardListItemMap.begin(); iter != m_backForwardListItemMap.end();
++iter) {

The WebKit style is to put end in a local variable. Something like

WebBackForwardListItemMap::iterator iter = m_backForwardListItemMap.begin(),
end = ...


More information about the webkit-reviews mailing list