[webkit-reviews] review granted: [Bug 64591] Use requestAnimationFrame callbacks to pump CSS animations : [Attachment 124809] Fixing pedantic presumbit check on (doubleValue == 0) expression.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 9 11:39:02 PST 2012
James Robinson <jamesr at chromium.org> has granted Joel Webber
<jgw at chromium.org>'s request for review:
Bug 64591: Use requestAnimationFrame callbacks to pump CSS animations
https://bugs.webkit.org/show_bug.cgi?id=64591
Attachment 124809: Fixing pedantic presumbit check on (doubleValue == 0)
expression.
https://bugs.webkit.org/attachment.cgi?id=124809&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
R=me this looks great.
To Simon's earlier concern, if it turns out that animations don't look better
on some platforms's implementations of rAF then I think the way to address that
is to add an ENABLE to control whether software-driven animations use rAF or a
40Hz timer. I feel that we've done sufficient experimentation in chromium to
know that we definitely prefer the rAF mechanism to a 40Hz timer.
More information about the webkit-reviews
mailing list