[webkit-reviews] review granted: [Bug 78224] Code generators should support multiple values for the [CallWith=] attribute : [Attachment 126287] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 78224: Code generators should support multiple values for the [CallWith=]
attribute
https://bugs.webkit.org/show_bug.cgi?id=78224

Attachment 126287: Patch
https://bugs.webkit.org/attachment.cgi?id=126287&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126287&action=review


> Source/WebCore/bindings/scripts/CodeGenerator.pm:641
> +sub CallWithContains

This doesn't seem specific to CallWith.  Should we give this a more general
name like "ExtendedAttributeContains" or "AttributeContains"?

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1457
>  sub GenerateCallWith

Should this function error out if there's something in the CallWith attribute
that we don't understand?