[webkit-reviews] review canceled: [Bug 78085] Page should have less intrusive way to associate API implementation objects. : [Attachment 126272] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has canceled MORITA Hajime
<morrita at google.com>'s request for review:
Bug 78085: Page should have less intrusive way to associate API implementation
objects.
https://bugs.webkit.org/show_bug.cgi?id=78085

Attachment 126272: Patch
https://bugs.webkit.org/attachment.cgi?id=126272&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126272&action=review


I really like the approach.  A few comments below.  It looks like you've got
some test failures to work through.

> Source/WebCore/page/Page.cpp:230
> +    notifyDestroyedToSupplements();

We might also want a PageDestructionObserver, similar to
FrameDestructionObserver, but we can add that in a future patch.

> Source/WebCore/page/PageSupplement.h:41
> +class PageSupplementKey {
> +    WTF_MAKE_NONCOPYABLE(PageSupplementKey);
> +public:
> +    PageSupplementKey() { }
> +};

You might consider using AtomicStrings as the keys.