[webkit-reviews] review granted: [Bug 78211] [GTK] EWS command-line option to run the tests : [Attachment 126276] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 10:40:50 PST 2012


Adam Barth <abarth at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 78211: [GTK] EWS command-line option to run the tests
https://bugs.webkit.org/show_bug.cgi?id=78211

Attachment 126276: Patch
https://bugs.webkit.org/attachment.cgi?id=126276&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126276&action=review


> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:48
> +	   options = [make_option("--run-tests", action="store_true",
dest="tests", default=self._default_run_tests, help="Run the Layout tests for
each patch")]

Can we name this run_tests ?  We generally like to make the names in the code
match the command line names.


More information about the webkit-reviews mailing list