[webkit-reviews] review denied: [Bug 74097] [Chromium] Continue compositions at the current selection if composition node is removed. : [Attachment 126046] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 74097: [Chromium] Continue compositions at the current selection if
composition node is removed.
https://bugs.webkit.org/show_bug.cgi?id=74097

Attachment 126046: Patch
https://bugs.webkit.org/attachment.cgi?id=126046&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126046&action=review


r- to remove from the review queue while john adds another test case.

>>> LayoutTests/fast/events/ime-composition-events-002.html:47
>>> +	 textInputController.setMarkedText('1', 0, 1);
>> 
>> You may need to skip this test on Qt and GTK+.  Last I checked, they don't
yet implement textInputController.
> 
> Thanks for the heads up. I tried to build Qt and GKT today locally, but was
set back by not having the right build dependencies. However, I did notice some
seemingly non-trivial implementation of textInputController here:
Tools/DumpRenderTree/gtk/TextInputController.cpp and
Tools/DumpRenderTree/qt/TextInputControllerQt.cpp

Ah, you're right, it looks like textInputController.setMarkedText and
insertText are implemented in both GTK and Qt.	My mistake!