[webkit-reviews] review granted: [Bug 78042] [BlackBerry] Upstream DumpRenderTreeBlackBerry : [Attachment 126153] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 78042: [BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Attachment 126153: Patch
https://bugs.webkit.org/attachment.cgi?id=126153&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126153&action=review


> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:266
> +void LayoutTestController::setPrivateBrowsingEnabled(bool flag)
> +{
> +    UNUSED_PARAM(flag);
> +    notImplemented();
> +}

I think we would support this one in a followup :)

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:470
> +    if (keyStr == "WebKitUsesPageCachePreferenceKey")
> +	  
BlackBerry::WebKit::DumpRenderTree::currentInstance()->page()->settings()->setM
aximumPagesInCache(1);
> +    else if (keyStr == "WebKitUsePreHTML5ParserQuirks")
> +	   mainFrame->page()->settings()->setUsePreHTML5ParserQuirks(true);
> +    else if (keyStr == "WebKitTabToLinksPreferenceKey")
> +	   DumpRenderTreeSupport::setLinksIncludedInFocusChain(valueStr ==
"true" || valueStr == "1");
> +    else if (keyStr == "WebKitHyperlinkAuditingEnabled")
> +	   mainFrame->page()->settings()->setHyperlinkAuditingEnabled(valueStr
== "true" || valueStr == "1");

we could also support the preference needed for spatial navigation tests here
too I think

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:631
> +    if (!mainFrame)
> +	   return;
> +    mainFrame->page()->settings()->setAllowFileAccessFromFileURLs(enabled);

newline here for consistency

> Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:638
> +void LayoutTestController::setAllowUniversalAccessFromFileURLs(bool enabled)

> +{
> +    if (!mainFrame)
> +	   return;
> +   
mainFrame->page()->settings()->setAllowUniversalAccessFromFileURLs(enabled);

ditto