[webkit-reviews] review denied: [Bug 78222] Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound. : [Attachment 126281] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 04:45:46 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 78222: Web Inspector: Timeline memory graph would have been more useful if
it had used minUsedHeapSize as the lower bound. Currently it uses zero as the
lower bound.
https://bugs.webkit.org/show_bug.cgi?id=78222

Attachment 126281: Patch
https://bugs.webkit.org/attachment.cgi?id=126281&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126281&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:582
> +	   var delta = (maxUsedHeapSize - minUsedHeapSize) * 0.05;

Why not to shift the entire graph 5px?


More information about the webkit-reviews mailing list