[webkit-reviews] review granted: [Bug 77543] Web Inspector: Support hiding scripts panel debug sidebar. : [Attachment 126122] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 77543: Web Inspector: Support hiding scripts panel debug sidebar.
https://bugs.webkit.org/show_bug.cgi?id=77543

Attachment 126122: Patch
https://bugs.webkit.org/attachment.cgi?id=126122&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126122&action=review


> Source/WebCore/inspector/front-end/SidebarOverlay.js:40
> +    WebInspector.DialogDelegate.call(this);

Overlay is not a dialog. We should come up with a better abstraction.

> Source/WebCore/inspector/front-end/SidebarOverlay.js:68
> +	   this._view.markAsRoot();

Why do you mark this view as root? It could have a valid element ancestor.