[webkit-reviews] review granted: [Bug 78123] Web Inspector: toggle Edit as HTML on F2, drag nodes up / down upon Ctrl(Cmd) Up / Down. : [Attachment 126102] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 03:16:34 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 78123: Web Inspector: toggle Edit as HTML on F2, drag nodes up / down upon
Ctrl(Cmd) Up / Down.
https://bugs.webkit.org/show_bug.cgi?id=78123

Attachment 126102: Patch
https://bugs.webkit.org/attachment.cgi?id=126102&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
+	     if (event.keyIdentifier === "Down" && node.nextSibling &&
node.parentNode) {
+		 node.moveTo(node.parentNode, node.nextSibling.nextSibling,
this._selectNodeAfterEdit.bind(this, null, treeElement.expanded));

Will it work fine if node.nextSibling.nextSibling === null?


More information about the webkit-reviews mailing list