[webkit-reviews] review denied: [Bug 77884] [Qt][WK2] Can't use TAB key to navigate on webpage links : [Attachment 126141] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 00:27:49 PST 2012


Simon Hausmann <hausmann at webkit.org> has denied Hugo Parente Lima
<hugo.lima at openbossa.org>'s request for review:
Bug 77884: [Qt][WK2] Can't use TAB key to navigate on webpage links
https://bugs.webkit.org/show_bug.cgi?id=77884

Attachment 126141: Patch
https://bugs.webkit.org/attachment.cgi?id=126141&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Making the tab preference available to us in WK2 makes sense to me, but turning
this into a WebCore::Setting sounds like something that should be dealt with in
a separate change.

I'm not sure the move to WC::Settings is actually worth it, but if it's done
then I suppose it should replace the existing ChromeClient's keyboardUIMode().
Having both, a WC::Setting _and_ the virtual keyboardUIMode() would be wrong
IMHO.


More information about the webkit-reviews mailing list