[webkit-reviews] review requested: [Bug 78079] [WebSocket] Add WebSocket extension support : [Attachment 126186] added test rebaseline

[bugzilla-daemon at webkit.org]

Yuta Kitamura <yutak at chromium.org> has asked  for review:
Bug 78079: [WebSocket] Add WebSocket extension support
https://bugs.webkit.org/show_bug.cgi?id=78079

Attachment 126186: added test rebaseline
https://bugs.webkit.org/attachment.cgi?id=126186&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126186&action=review


Looks almost fine to me.

> Source/WebCore/websockets/WebSocketExtensions.cpp:224
> +	   for (index = 0; index < m_extensions.size(); ++index) {
> +	       Extension* extension = m_extensions[index].get();
> +	       if (equalIgnoringCase(extensionToken,
extension->m_processor->extensionToken()) && !extension->m_responseHandled) {
> +		   extension->m_responseHandled = true;
> +		   if
(extension->m_processor->processResponse(extensionParameters))
> +		       break;
> +		   m_failureReason = extension->m_processor->failureReason();
> +		   return false;
> +	       }
> +	   }

I have two questions:

(1) What will happen if the server provides two extensions having the same
extention identifier, such as "foo;a=1, foo;b=2"?
(2) Why do you compare the extention name case-insensitively? I could not find
such a requirement in the spec (but I may have missed it).