[webkit-reviews] review granted: [Bug 77934] Replacement text should be available from the marker. : [Attachment 125992] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 77934: Replacement text should be available from the marker.
https://bugs.webkit.org/show_bug.cgi?id=77934

Attachment 125992: Patch
https://bugs.webkit.org/attachment.cgi?id=125992&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125992&action=review


> Source/WebCore/testing/Internals.h:84
> +    String markerDescriptionForNode(Node*, const String&, unsigned,
ExceptionCode&);

nit: We shouldn't omit the argument names of 2nd and 3rd arguments. It's hard
to understand what they are.

> Source/WebCore/testing/Internals.h:118
> +    DocumentMarker* markerAt(Node*, const String&, unsigned,
ExceptionCode&);

ditto.

> LayoutTests/editing/spelling/spelling-marker-description.html:43
> +    window.setTimeout(function() { verify(nretry-1); }, 0);

nit: Should have whitespace around '-'.