[webkit-reviews] review denied: [Bug 77493] PopStateEvent.state should use the same object as history.state : [Attachment 126201] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Pablo Flouret <pablof at motorola.com>'s
request for review:
Bug 77493: PopStateEvent.state should use the same object as history.state
https://bugs.webkit.org/show_bug.cgi?id=77493

Attachment 126201: Patch
https://bugs.webkit.org/attachment.cgi?id=126201&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126201&action=review


> Source/WebCore/bindings/js/JSPopStateEventCustom.cpp:53
> +    return jsHistory->get(exec, Identifier(exec, "state"));

If the web page installs a getter on the history object, does this call that
getter?  (Seems like something we should test.)

> Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp:55
> +    return
toV8(history).As<v8::Object>()->Get(v8::String::NewSymbol("state"));

I would think you'd want to get the hidden property rather than the real
property.  The hidden property can't be manipulated by the web page where as
the real property can.