[webkit-reviews] review granted: [Bug 78042] [BlackBerry] Upstream DumpRenderTreeBlackBerry : [Attachment 126121] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 78042: [BlackBerry] Upstream DumpRenderTreeBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=78042

Attachment 126121: Patch
https://bugs.webkit.org/attachment.cgi?id=126121&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126121&action=review


> Tools/DumpRenderTree/blackberry/EventSender.cpp:325
> +    for (Vector<BlackBerry::Platform::TouchPoint>::iterator it =
touches.begin();
> +	    it != touches.end();
> +	    ++it) {

bad identation

> Tools/DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:87
> +    return
BlackBerry::WebKit::DumpRenderTree::currentInstance()->page()->goBackOrForward(
m_howFar);

as a follow up we could rename ::currentInstance to ::instance maybe.