[webkit-reviews] review granted: [Bug 77804] [chromium] Add support for pinch gesture in the threaded compositor : [Attachment 126109] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted sadrul at chromium.org's request
for review:
Bug 77804: [chromium] Add support for pinch gesture in the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=77804

Attachment 126109: Patch
https://bugs.webkit.org/attachment.cgi?id=126109&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126109&action=review


R=me with one request for documentation and one very minor style nit.

> Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp:196
> +	   m_inputHandlerClient->pinchGestureUpdate(gestureEvent.deltaX,
IntPoint(gestureEvent.x, gestureEvent.y));

I suppose this means that pinches are 1-dimensional and we're using deltaX to
represent the amount - could you please document this somewhere (such as in
WebInputEvent where it defines WebGestureEvent)?

> Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp:252
> +    gesture.deltaX = 1.5f;

don't put the trailing "f" on this. see "Floating point literals" in
http://www.webkit.org/coding/coding-style.html