[webkit-reviews] review denied: [Bug 78001] [Qt] Use QRawFont when building with Qt 5 : [Attachment 126112] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 78001: [Qt] Use QRawFont when building with Qt 5
https://bugs.webkit.org/show_bug.cgi?id=78001

Attachment 126112: Patch
https://bugs.webkit.org/attachment.cgi?id=126112&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126112&action=review


Rest of the patch LGTM, just one nitpick left :)

> Source/WebCore/platform/graphics/qt/FontQt.cpp:271
> +    if (isSmallCaps() || typesettingFeatures() & Kerning || m_wordSpacing ||
m_letterSpacing)
> +	   overrides << range;
> +
> +    if (!overrides.isEmpty())
> +	   layout->setAdditionalFormats(overrides);

I suppose you forgot this part? :) I'm not so particular about the stylistic
aspect of this function, but I'd like at least the if () to be simplified. We
shouldn't duplicate the if (m_wordSpacing || isSmallCaps || ...) part.