[webkit-reviews] review granted: [Bug 78060] [chromium] Add a layout test for losing the compositor context with a video playing : [Attachment 125960] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 78060: [chromium] Add a layout test for losing the compositor context with
a video playing
https://bugs.webkit.org/show_bug.cgi?id=78060

Attachment 125960: Patch
https://bugs.webkit.org/attachment.cgi?id=125960&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125960&action=review


>
LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video.ht
ml:7
> +    layoutTestController.dumpAsText(true);  // This is only useful as a
pixel test.

Why call dumpAsText() at all - there is no text output? I would either remove
this call completely so it doesn't generate an "expected" text file, or include
some text in the test so the text file say something about why it is empty.

>>
LayoutTests/platform/chromium/compositing/lost-compositor-context-with-video.ht
ml:27
>> +<video oncanplaythrough="test();"></video>
> 
> Heads-up that chromium has a bug where it fires canplaythrough immediately;
since you only seek to 0 that should be fine.

Can 'canplaythrough' fire when readyState is HAVE_NOTHING? If so, this will
fail because setting currentTime will throw an exception.