[webkit-reviews] review denied: [Bug 78114] Add a perf test for the CSS parser. : [Attachment 126083] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 78114: Add a perf test for the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=78114

Attachment 126083: Patch
https://bugs.webkit.org/attachment.cgi?id=126083&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126083&action=review


> PerformanceTests/Parser/resources/style.css:2
> +/* Facebook */
> +/*1328647392,176833978*/

We probably have to get permission from Facebook et al to use their styles.

> PerformanceTests/Parser/resources/style.css:2913
> +.view-error .oops-msg .icon{margin-left:13px}.view-error .oops-msg
.shadow{background:url(http://l.yimg.com/a/i/ww/met/shadow_icon_32_101508.png)
no-repeat;margin-left:8px;height:6px;width:34px;float:left;clear:left}

We probably also need to sanitize URLs in the css.  We don't want to hit a live
page when running the perf tests.

> PerformanceTests/Parser/resources/style.css:6147
> +/* lib/yui/2.8.1/container/assets/container-core-min.css */

YUI might be OK.  You'd have to check the license.