[webkit-reviews] review granted: [Bug 78080] REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle] : [Attachment 126100] with API test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 8 09:25:00 PST 2012


Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 78080: REGRESSION (r106681): Null check missing in [WebFrame(WebInternal)
_typingStyle]
https://bugs.webkit.org/show_bug.cgi?id=78080

Attachment 126100: with API test
https://bugs.webkit.org/attachment.cgi?id=126100&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126100&action=review


> Tools/TestWebKitAPI/Tests/mac/TypingStyleCrash.mm:32
> +    WebView *webView = [[WebView alloc] initWithFrame:NSZeroRect
frameName:@"" groupName:@""];

I think another way to do the same thing is: [[WebView alloc] init]. I believe
those arguments are the defaults.


More information about the webkit-reviews mailing list