[webkit-reviews] review denied: [Bug 77935] Disable adding a shadow root to elements having a dynamic built-in shadow root. : [Attachment 125779] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 77935: Disable adding a shadow root to elements having a dynamic built-in
shadow root.
https://bugs.webkit.org/show_bug.cgi?id=77935

Attachment 125779: Patch
https://bugs.webkit.org/attachment.cgi?id=125779&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125779&action=review


>> Source/WebCore/dom/ShadowRoot.h:49
>> +	enum CheckUserShadowRootAllowance {
> 
> It might be better to rename this to reflect the caller intent, eg
> 
> enum (mumble) {
>   CreatingUserAgentShadowRoot,
>   CreatingAuthorShadowRoot
> }
> 
> ?

I like Dominic's idea here. Other than that, the patch looks fine.