[webkit-reviews] review requested: [Bug 78005] [Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer. : [Attachment 126094] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 8 09:00:47 PST 2012
Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked for review:
Bug 78005: [Qt] Control the lifetime of TiledBackingStores in WebGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=78005
Attachment 126094: Patch
https://bugs.webkit.org/attachment.cgi?id=126094&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
I thought that drawsContent() was also true when we had a directly composited
image.
- Cleared the backing stores in setDrawsContent(false)
- Moved the early return for if not drawsContent under the image case in
updateContentsBuffers
- Removed the check for drawsContent in tiledBackingStoreContentsRect since we
won't have a backing store in that case
More information about the webkit-reviews
mailing list