[webkit-reviews] review granted: [Bug 78113] Web Inspector: heap snapshot: implement Distance column in Object's retaining tree. : [Attachment 126087] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 78113: Web Inspector: heap snapshot: implement Distance column in Object's
retaining tree.
https://bugs.webkit.org/show_bug.cgi?id=78113

Attachment 126087: Patch
https://bugs.webkit.org/attachment.cgi?id=126087&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126087&action=review


> Source/WebCore/inspector/front-end/HeapSnapshot.js:946
> +	   this._distancesToWindow = new Array(this.nodeCount);

Use {} instead of array?

> Source/WebCore/inspector/front-end/HeapSnapshot.js:969
> +	       var node = list[index++]; // shift generates too much garbage.

Why not just use shift here?