[webkit-reviews] review granted: [Bug 63451] [GTK] Embedded GtkWidgets are not drawn : [Attachment 126053] Fixed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Dan Vrátil
<dvratil at redhat.com>'s request for review:
Bug 63451: [GTK] Embedded GtkWidgets are not drawn
https://bugs.webkit.org/show_bug.cgi?id=63451

Attachment 126053: Fixed patch
https://bugs.webkit.org/attachment.cgi?id=126053&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126053&action=review


> Source/WebKit/gtk/webkit/webkitwebview.cpp:672
> +    /* Chaining up to the parent forces child widgets to be drawn. */
> +    GTK_WIDGET_CLASS(webkit_web_view_parent_class)->draw(widget, cr);
> +

You removed the ::paint method for GTK+ 2.x, but you did not chain up in
webkit_web_view_expose. We use C++ style comments usually. :) No worries
though. I will fix those two minor issues and land this patch. Thank you for
taking the time to investigate this issue!