[webkit-reviews] review denied: [Bug 78082] [BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp} : [Attachment 126009] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 78082: [BlackBerry] Upstream InspectorClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=78082

Attachment 126009: Patch
https://bugs.webkit.org/attachment.cgi?id=126009&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126009&action=review


Looks good, can be cleaned up a bit more.

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:25
> +#include "FrameView.h"

Do you need this include?

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:26
> +#include "IntRect.h"

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:27
> +#include "IntSize.h"

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:132
> +    CString utf8Message =  message.utf8();

CString utf8Message = message.utf8();

> Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:24
> +#include "IntRect.h"

Do you need this include?