[webkit-reviews] review denied: [Bug 77917] Web Inspector: In Inspector.json PropertyDescriptor.writable should be declared optional : [Attachment 125965] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 8 01:50:01 PST 2012
Pavel Feldman <pfeldman at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 77917: Web Inspector: In Inspector.json PropertyDescriptor.writable should
be declared optional
https://bugs.webkit.org/show_bug.cgi?id=77917
Attachment 125965: Patch
https://bugs.webkit.org/attachment.cgi?id=125965&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125965&action=review
> Source/WebCore/inspector/InjectedScriptSource.js:236
> + if (typeof descriptor.get != "function") {
Should be !==, no need for {}
> Source/WebCore/inspector/InjectedScriptSource.js:239
> + if (typeof descriptor.set != "function") {
ditto
More information about the webkit-reviews
mailing list