[webkit-reviews] review denied: [Bug 77938] SVGTRefElement shouldn't dynamically create a shadow root. : [Attachment 126005] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 77938: SVGTRefElement shouldn't dynamically create a shadow root.
https://bugs.webkit.org/show_bug.cgi?id=77938

Attachment 126005: Patch
https://bugs.webkit.org/attachment.cgi?id=126005&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126005&action=review


r- for the missing tests for now. Patch looks good in general.

> Source/WebCore/ChangeLog:9
> +	   SVGTRefElement creates a shadow root dynamically. This will cause a
problem to support
> +	   multiple shadow subtrees. So it should be created in a constructor
phase.
> +
> +	   Reviewed by NOBODY (OOPS!).

These blocks should be swapped.
Can you include a testcase that shows this problem? Otherwise this will break
again in future.

> Source/WebCore/svg/SVGTRefElement.cpp:61
> -    return adoptRef(new SVGTRefElement(tagName, document));
> +    RefPtr<SVGTRefElement> elem = adoptRef(new SVGTRefElement(tagName,
document));
> +    elem->createShadowSubtree();
> +    return elem.release();

s/elem/element/ - no abbreviations please.