[webkit-reviews] review requested: [Bug 77525] SelectorChecker::checkSelector: move parameters into a struct : [Attachment 126011] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 7 22:52:50 PST 2012
Roland Steiner <rolandsteiner at chromium.org> has asked for review:
Bug 77525: SelectorChecker::checkSelector: move parameters into a struct
https://bugs.webkit.org/show_bug.cgi?id=77525
Attachment 126011: Patch
https://bugs.webkit.org/attachment.cgi?id=126011&action=review
------- Additional Comments from Roland Steiner <rolandsteiner at chromium.org>
New patch, removed isSubSelector parameter to constructor, removed
setCompoundSelector & replaced with sub-selector and compound selector 'copy'
constructors. Note: the compound selector constructor ignores the old context
for now, however, the signature will come in handy when being extended for
<style scoped>. Also updated variable names 'e'->'element' and
'sel'->'selector' in checkOneSelector() as requested. The only real changes in
this function concern pseudoAny and pseudoNot.
More information about the webkit-reviews
mailing list