[webkit-reviews] review canceled: [Bug 78076] Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter] attribute : [Attachment 125995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 21:49:29 PST 2012


Kentaro Hara <haraken at chromium.org> has canceled  review:
Bug 78076: Rename [HasOverridingNameGetter] attribute to [CustomNamedGetter]
attribute
https://bugs.webkit.org/show_bug.cgi?id=78076

Attachment 125995: Patch
https://bugs.webkit.org/attachment.cgi?id=125995&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125995&action=review


>> Source/WebCore/bindings/scripts/test/TestOverridingNameGetter.idl:32
>> +	    CustomNamedGetter
> 
> Should we change the name of this test file since it refers to the old
attribute name?

Nice catch. Renamed the file to TestCustomNamedGetter.idl, and committed
manually (to avoid style check errors).


More information about the webkit-reviews mailing list