[webkit-reviews] review granted: [Bug 77843] [BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp} : [Attachment 125976] Patch v3

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted  review:
Bug 77843: [BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843

Attachment 125976: Patch v3
https://bugs.webkit.org/attachment.cgi?id=125976&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125976&action=review


Looks good, please have a look at fixing the nits before landing.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h:2
> + * Copyright (C) 2009, 2010, 2011 Research In Motion Limited. All rights
reserved.

Still needs 2012.

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h:95
> +    virtual void runOpenPanel(Frame*, WTF::PassRefPtr<FileChooser>);

WTF is probably not needed, ChromeClient.h does not need it either.