[webkit-reviews] review granted: [Bug 78064] Web Inspector: avoid making a window for the Inspector when docked : [Attachment 125972] Proposed Change

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 78064: Web Inspector: avoid making a window for the Inspector when docked
https://bugs.webkit.org/show_bug.cgi?id=78064

Attachment 125972: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=125972&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=125972&action=review


> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:252
> +    }

Can this code be shared with the code in platformDidClose?

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:267
> +    [m_inspectorView.get() setHidden:NO];

How would it have been detached if it was hidden? I don't see how the undock
button could have been pressed in this case.