[webkit-reviews] review granted: [Bug 78022] [Chromium] pack Gamepad shared memory structure : [Attachment 125948] add compile_asserts

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Scott Graham <scottmg at chromium.org>'s
request for review:
Bug 78022: [Chromium] pack Gamepad shared memory structure
https://bugs.webkit.org/show_bug.cgi?id=78022

Attachment 125948: add compile_asserts
https://bugs.webkit.org/attachment.cgi?id=125948&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=125948&action=review


Oh, at first I didn't realize these were Chromium headers.  Looks fine.  As the
style-bot says, fishd is supposed to approve this sort of thing.  Given that
he's out this week, I think it's OK to move foward with this r=me, TBR=fishd.

> Source/WebKit/chromium/public/platform/WebGamepads.h:50
> +COMPILE_ASSERT(sizeof(WebGamepads) == 1864, WebGamepads_has_wrong_size);

WebKit has used this type of thing in the past to find compiler configuration
bugs between platforms. :)